On 17/01/12 16:49, Brad Jorsch wrote: >> --- /dev/null >> +++ b/wrlib/alpha_combine.c >> @@ -0,0 +1,68 @@ >> +/* alpha_combine.c - Alpha channel combination, based on Gimp 1.1.24 >> + * >> + * Raster graphics library >> + * >> + * Copyright (c) 1997-2003 Alfredo K. Kojima > > That's obviouly wrong. The only difference between this file in my > ancient patch and this verion is the function name, the comment, the > #include, and some whitespace. > > After 11 years (that makes me feel old), I don't remember whether any of > the code is based on code from the Gimp or if it was rewritten from > scratch after working out the algorithm. The trickiest bit resembles the > macro INT_MULT defined in app/paint_funcs.c.[1] The credit from that > file is: > * The GIMP -- an image manipulation program > * Copyright (C) 1995 Spencer Kimball and Peter Mattis > > [1] ftp://ftp.gimp.org/pub/gimp/v1.1/old/v1.1.24/gimp-1.1.24.tar.bz2 > >
Hi Brad, the mistake is mine. I take your patch and I include the changes in the raster.c file. Some things are in the same place (the library don't changes this part) but in other parts is different. Really I am not sure if all is correct, but seems to be ok. With the file alpha_combine.c I copied the contents from your Debian patch and I pasted in the file, but the file don't had header (only one line). Then, here is the problem, I copied the header form other file in the same folder, but I don't change the name of Alfredo. I am sorry for that. Later, Cristophe made some changes (function name,...), but the mistake is mine. I don't want to do it, because if you see the commit info, I add this: "here are some problems in the alpha channel support, as is reported at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=72917 This patch add a new alpha_combine function, based on Gimp. This function is called when needed in the raster.c functions. This patch is based on the Brad Jorsch <[email protected]> patch for the 0.62.1-0.1 version." If you are agree, I will make a patch to change the line: * Copyright (c) 1997-2003 Alfredo K. Kojima To: * Original patch of Brad Jorsch <[email protected]> * Function from The GIMP -- an image manipulation program * Copyright (C) 1995 Spencer Kimball and Peter Mattis If you want other text, please, post it. Again, sorry for the mistake. Best Regards, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
