On Fri, 27 Jan 2012 at 12:52:06 +0100, BALATON Zoltan wrote: > > > >But a global variable can be defined only once, and now whenever > >you include WindowMaker.h it will be defined in that file. > > I also think the original version is cleaner, because the variable > is defined only once and then declared for use as extern in the > header. This ensures that all files use the same variable. If the > definition is in the header then the variable is always defined even > if the resulting code is not linked to main.o. This is probably not > what's intended.
Exactly. I'll skip this patch. My time to review is short right now, I'll take a look at the rest during the weekend if all goes well. If more people have comments, that will great. -- To unsubscribe, send mail to [email protected].
