On Fri, 27 Jan 2012 12:02:45 -0200, Haroldo Gambini Santos wrote:
Hi Rodolfo,
If I understand your proposal, there might be a problem:
If you define a variable in a C header which is included in two
source files then these files when compiled will reserve space for
this variable in *two different* memory locations, isn't ???
Yes yes, I didn't what I was thinking. Some (most) patches are wrong.
On 27-01-2012 10:04, Carlos R. Mafra wrote:
On Fri, 27 Jan 2012 at 12:52:06 +0100, BALATON Zoltan wrote:
But a global variable can be defined only once, and now whenever
you include WindowMaker.h it will be defined in that file.
I also think the original version is cleaner, because the variable
is defined only once and then declared for use as extern in the
header. This ensures that all files use the same variable. If the
definition is in the header then the variable is always defined
even
if the resulting code is not linked to main.o. This is probably not
what's intended.
Exactly. I'll skip this patch.
My time to review is short right now, I'll take a look at the rest
during the weekend if all goes well.
If more people have comments, that will great.
--
=============================================================
Haroldo Gambini Santos
Computing Department - Universidade Federal de Ouro Preto - UFOP
email: haroldo [at ] iceb.ufop.br
home/research page: www.decom.ufop.br/haroldo/
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
