>From 659853acfdc503df3762cfd42f18aa52787d8bda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?= <[email protected]>
Date: Sun, 4 Mar 2012 17:14:28 +0100
Subject: [PATCH 8/8] WindowMaker: icon.c comments added
Some comments added to icon.c file.
---
src/icon.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/icon.c b/src/icon.c
index b4491c8..a56ab73 100644
--- a/src/icon.c
+++ b/src/icon.c
@@ -574,15 +574,19 @@ void wIconUpdate(WIcon * icon)
icon->pixmap = makeIcon(scr, wwin->net_icon_image,
icon->show_title,
icon->shadowed,
icon->tile_type, icon->highlighted);
} else if (wwin && wwin->wm_hints && (wwin->wm_hints->flags &
IconPixmapHint)) {
+ /* Get the Pixmap from the wm_hints, else, from the user */
if (get_pixmap_icon_from_wm_hints(scr, wwin, icon))
get_pixmap_icon_from_user_icon(scr, icon);
} else {
+ /* Get the Pixmap from the user */
get_pixmap_icon_from_user_icon(scr, icon);
}
+ /* No pixmap, set default background */
if (icon->pixmap != None)
XSetWindowBackgroundPixmap(dpy, icon->core->window,
icon->pixmap);
+ /* Paint it */
XClearWindow(dpy, icon->core->window);
wIconPaint(icon);
}
@@ -611,6 +615,7 @@ void get_pixmap_icon_from_user_icon(WScreen *scr, WIcon *
icon)
} else {
wwarning(_("could not find default icon
\"%s\""), file);
}
+ /* FIXME: Probably wfree(file) here! */
}
image = wIconValidateIconSize(scr, image,
wPreferences.icon_size);
--
1.7.7.3
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
>From 659853acfdc503df3762cfd42f18aa52787d8bda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?= <[email protected]>
Date: Sun, 4 Mar 2012 17:14:28 +0100
Subject: [PATCH 8/8] WindowMaker: icon.c comments added
Some comments added to icon.c file.
---
src/icon.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/icon.c b/src/icon.c
index b4491c8..a56ab73 100644
--- a/src/icon.c
+++ b/src/icon.c
@@ -574,15 +574,19 @@ void wIconUpdate(WIcon * icon)
icon->pixmap = makeIcon(scr, wwin->net_icon_image, icon->show_title,
icon->shadowed, icon->tile_type, icon->highlighted);
} else if (wwin && wwin->wm_hints && (wwin->wm_hints->flags & IconPixmapHint)) {
+ /* Get the Pixmap from the wm_hints, else, from the user */
if (get_pixmap_icon_from_wm_hints(scr, wwin, icon))
get_pixmap_icon_from_user_icon(scr, icon);
} else {
+ /* Get the Pixmap from the user */
get_pixmap_icon_from_user_icon(scr, icon);
}
+ /* No pixmap, set default background */
if (icon->pixmap != None)
XSetWindowBackgroundPixmap(dpy, icon->core->window, icon->pixmap);
+ /* Paint it */
XClearWindow(dpy, icon->core->window);
wIconPaint(icon);
}
@@ -611,6 +615,7 @@ void get_pixmap_icon_from_user_icon(WScreen *scr, WIcon * icon)
} else {
wwarning(_("could not find default icon \"%s\""), file);
}
+ /* FIXME: Probably wfree(file) here! */
}
image = wIconValidateIconSize(scr, image, wPreferences.icon_size);
--
1.7.7.3
