>>>>> "RkG" == Rodolfo kix Garcia <[email protected]> writes:
Hi
There are much differences in style of other kind in original patch
(like opening brace on next line after if, etc.).
I did some white space fix to match WindowMaker source style (WindowMaker
uses tabs while patch uses spaces). But that's all what I did, I didn't
change original patch much.
If you really considering including this patch and formatting is the
only issue, I can adjust formatting to match WindowMaker style.
PS. By the way, I'm not disputing coding style, and I consider that in
patches original style must be followed.
But in general I prefer first case: in case when you add another
statement to if body, diff would be just one line instead of three, and
it definitely easier to comprehend. And the cost is not too high, just
one line of vertical space.
RkG>> +static char*
RkG>> +captureShortcut(Display *dpy, AppSettingsPanel *panel)
RkG>> These lines should be in one line. This problem is in all functions.
RkG>> + if (ev.xkey.state & ControlMask) {
RkG>> + strcat(buffer, "Control+");
RkG>> + }
RkG>> These lines should be:
RkG>> + if (ev.xkey.state & ControlMask)
RkG>> + strcat(buffer, "Control+");
RkG>> Are many lines like this.
--
Bona diagnosis, bona curatio.
--
To unsubscribe, send mail to [email protected].
