>>>>> "CRM" == Carlos R Mafra <[email protected]> writes:

You won't believe :) I didn't even know that it's possible to assign
shortcuts to root menu items.

If such easy workaround is possible, the question of pushing this patch
upstream is not so important for me.

But still good to have it in upstream. If I haven't found shortcuts in
root menu, but I found shortcuts for dockapps, probably other users find
shortcuts for dockapps more useful.

I can edit patch to fix "if"-s, remove redundant trimstr(), and fix up
whitespace thoroughly (still there are some places where I missed to fix
whitespace). If I do, someone consider to review code for including it
to upstream?

    CRM>> I understand that you are not the original author. But
    CRM>> unfortunately that doesn't matter much in this case, because
    CRM>> the patch adds code which will probably have to cleaned up
    CRM>> somehow later - the trimstr() function was the easiest to
    CRM>> detect case.

    CRM>> As this patch duplicates code and (to a smaller degree)
    CRM>> functionality - why not use the root menu shortcuts directly?
    CRM>> - I don't think it has a strong appeal right now.

-- 
Si tacuisses, philosophus mansisses.


-- 
To unsubscribe, send mail to [email protected].

Reply via email to