On Thu,  7 Jun 2012 at 23:45:02 +0200, Rodolfo García Peñas wrote:

One more thing I noticed.

> +static char *get_icon_cache_path(void)
> +{
> +     char *prefix, *path;
> +     int len, ret;
> +
> +     prefix = wusergnusteppath();
> +     len = strlen(prefix) + strlen(CACHE_ICON_PATH) + 1;
> +     path = wmalloc(len);
> +     snprintf(path, len, "%s%s", prefix, CACHE_ICON_PATH);
> +
> +     ret = create_path(path);

You define create_path() only in the next patch, you must do it before
using it.

And I must say I don't like your create_path() being able to create
stuff outside the GNUstep folder. Can't you use the wmkdirhier() from
the WINGs library instead?


-- 
To unsubscribe, send mail to [email protected].

Reply via email to