El 09.06.2012 18:38, Carlos R. Mafra escribió:
On Sat, 9 Jun 2012 at 17:05:58 +0100, Carlos R. Mafra wrote:
On Thu, 7 Jun 2012 at 23:45:02 +0200, Rodolfo García Peñas wrote:
> Subject: [PATCH 03/10] New functions in icon.c
>
> This patch creates some functions:
>
> +
> +static RImage *get_wwindow_image_from_wmhints(WWindow *wwin,
WIcon *icon)
> +{
> + RImage *image;
> +
> + if (wwin->wm_hints &&
> + (wwin->wm_hints->flags & IconPixmapHint) &&
> + wwin->wm_hints->icon_pixmap != None) {
> + image =
RCreateImageFromDrawable(icon->core->screen_ptr->rcontext,
> + wwin->wm_hints->icon_pixmap,
> + (wwin->wm_hints->flags &
IconMaskHint)
> + ? wwin->wm_hints->icon_mask :
None);
> + }
> + return image;
> +}
This function does not seem right - 'image' will be a random pointer
if
the conditions are false. You should initialize it to NULL.
Sorry, you did exactly this on patch 10. But you should have done it
here already.
Not sorry. I did it wrong.
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
