On Fri, 22 Jun 2012 at 17:16:29 +0100, Iain Patterson wrote: > Quoth Fons Adriaensen, > > >WM's 'unshade' seems to use multiple Expose events [...] even when > >all animations and 'superfluous effects' are disabled. > > With the attached patch I see fewer XMoveWindow() calls and > quicker shading.
> From 0f2befbbab700d4e4e4fd1f9cb570ec778e12822 Mon Sep 17 00:00:00 2001 > From: Iain Patterson <[email protected]> > Date: Fri, 22 Jun 2012 17:03:59 +0100 > Subject: [PATCH] Correct window shading logic. > > Typo in shade_animate() could cause windows to be animated when the > no_animations preference was set. > --- > src/actions.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/actions.c b/src/actions.c > index 4cf1f3d..08a0b4f 100644 > --- a/src/actions.c > +++ b/src/actions.c > @@ -1891,7 +1891,7 @@ static void shade_animate(WWindow *wwin, Bool what) > int y, s, w, h; > time_t time0 = time(NULL); > > - if (wwin->flags.skip_next_animation && wPreferences.no_animations) > + if (wwin->flags.skip_next_animation || wPreferences.no_animations) > return; > > switch(what) { Cool, I will add that Fons Adriaensen originally reported the problem in the commit message and apply it. Thanks a lot. -- To unsubscribe, send mail to [email protected].
