begin quoting Carlos R. Mafra as of Fri, Jul 20, 2012 at 02:35:53PM +0100: > On Fri, 20 Jul 2012 at 1:01:18 +0200, Rodolfo Garc??a Pe??as wrote: > > > -static void menu_parser_condition_ifmacro(WMenuParser parser, Bool > > check_exists); > > +static void menu_parser_condition_ifmacro(WMenuParser parser, > > + Bool check_exists); > > No, this is worse. The occasional long line is OK. Trying to satisfy a > 80 columns limit is not a good idea.
That's the stuff of a good knock-down argument. :) If you have a coding style line length limit (be it 72, 80, 90, 127, or 132 characters), trying to satisfy it is always a good idea. However. HOW one goes about keeping lines under the coding style limit is also important. It should be more than just "wrap long lines", as that's just lazy. :) Perhaps something can be done about the 29-character function name. Maybe there's a better parameter name than "check_exists" -- that does seem to be ambiguous, so perhaps a better (and shorter) name would be called for. -S. -- To unsubscribe, send mail to [email protected].
