On Fri, 20 Jul 2012 at 14:45:48 +0000, SJS wrote: > begin quoting Carlos R. Mafra as of Fri, Jul 20, 2012 at 02:35:53PM +0100: > > On Fri, 20 Jul 2012 at 1:01:18 +0200, Rodolfo Garc??a Pe??as wrote: > > > > > -static void menu_parser_condition_ifmacro(WMenuParser parser, Bool > > > check_exists); > > > +static void menu_parser_condition_ifmacro(WMenuParser parser, > > > + Bool check_exists); > > > > No, this is worse. The occasional long line is OK. Trying to satisfy a > > 80 columns limit is not a good idea.
... > Perhaps something can be done about the 29-character function name. > > Maybe there's a better parameter name than "check_exists" -- that does > seem to be ambiguous, so perhaps a better (and shorter) name would be > called for. Agree, the names seem to be too long. One possibility could be to rename the menu_parser_ preffix to mp_ since this is inside a file called menuparser.c. -- To unsubscribe, send mail to [email protected].
