On Sat, 03 Nov 2012, Carlos R. Mafra escribió: > The email subject is what goes into the logs as the patch summary. > > And "rimage pixmap split *_icon_from_wm_hints" is not good. > It does not parse. > > Furthermore you're splitting only one function, so why the *? > > I will change this to > > "Split get_pixmap_icon_from_wm_hints() into two"
Ok, no problem. I am not very good friend of commits titles, sorry. See that other commits have similar names: # 0003-rimage-pixmap-split-_icon_from_default_icon.patch # 0004-rimage-pixmap-split-_icon_from_user_icon.patch # 0005-rimage-pixmap-split-_icon_from_wm_hints.patch # 0010-rimage-pixmap-split-_icon_from_icon_win.patch Probably is good idea use the same pattern for them. Thanks kix > On Sat, 3 Nov 2012 at 19:53:58 +0100, Rodolfo García Peñas (kix) wrote: > > From: "Rodolfo García Peñas (kix)" <[email protected]> > > > > The function get_pixmap_icon_from_wm_hints() is splitted in two > > functions now: > > > > 1. get_rimage_icon_from_wm_hints, set the rimage at icon->image > > The code comes from the function get_pixmap_icon_from_default_icon() > > 2. The get_pixmap_icon_from_wm_hints() function, but now only converts > > the icon->file_image in icon->pixmap > > > -- > To unsubscribe, send mail to [email protected]. -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
