On Sun, 18 Nov 2012, Carlos R. Mafra escribió:

> On Sun, 18 Nov 2012 at 23:07:48 +0100, Rodolfo García Peñas (kix) wrote:
> > From: "Rodolfo García Peñas (kix)" <[email protected]>
> > 
> > This patch removes the wIconDestroy and the window always has icon.
> > This patch doesn't create the icon at the window creation! so yet
> > WWindow icon could be null.
> > 
> > This patch also adds this bug when the window is removed:
> > 
> > wmaker(RemoveFromStackList(stacking.c:567)): \
> > warning: RemoveFromStackingList(): window not in list
> > 
> > Because the stacking is not updated correctly.
> 
> I'm sorry, but why should I apply a patch which says
> 
>       "This patch also adds this bug"
> 
> What's going on here?

Is not a bug, is a issue. See the patch 0006-stacking-warning-removed.patch

The stacking is unbalanced, the window destroy removes the stacked icon, but
icon creation don't add it to the stack list. With this patch, the problem
flow up and we have this message log.

But now, we don't have this:

/usr/lib/WindowMaker/wmaker(catchXError(startup.c:177)): warning: error interno 
de X: RenderBadPicture (invalid Picture parameter)
        Request code: 149
        Request minor code: 7
        Resource ID: 0x801b9b
        Error serial: 190639

in the logs, because the icon is creation/destroy is balanced.

kix
-- 
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/


-- 
To unsubscribe, send mail to [email protected].

Reply via email to