On Sun, 18 Nov 2012 at 23:44:45 +0100, Rodolfo García Peñas wrote: > On Sun, 18 Nov 2012, Carlos R. Mafra escribió: > > > On Sun, 18 Nov 2012 at 23:07:48 +0100, Rodolfo García Peñas (kix) wrote: > > > From: "Rodolfo García Peñas (kix)" <[email protected]> > > > > > > This patch removes the wIconDestroy and the window always has icon. > > > This patch doesn't create the icon at the window creation! so yet > > > WWindow icon could be null. > > > > > > This patch also adds this bug when the window is removed: > > > > > > wmaker(RemoveFromStackList(stacking.c:567)): \ > > > warning: RemoveFromStackingList(): window not in list > > > > > > Because the stacking is not updated correctly. > > > > I'm sorry, but why should I apply a patch which says > > > > "This patch also adds this bug" > > > > What's going on here? > > Is not a bug, is a issue. See the patch 0006-stacking-warning-removed.patch
In that patch you simply removed the warning, and I couldn't understand your explanation there too. The warning seems to be legit since XDeleteContext() returns an error code XCNOENT. By removing the warning one misses this knowledge. One should avoid the warning by making the code pass the check instead of deleting it. And I couldn't see why you can remove it, the error is still there, it's not been addressed afaics. You may well be right and your series may well do the right things, but given the difficult to understand explanations I feel unconfortable in applying patches 3,4 and 6. I applied the other ones now. -- To unsubscribe, send mail to [email protected].
