On 27/01/2013 18:24, Andreas Bierfert wrote:
> Hi,
> 
> the following two patches change the parsing for generated menus
> from external commands to use the same code path as externally
> saved menus.
> 
> This way using an external menu file generated via 'wmmenugen >
> file' will actually do the same as running wmmenugen as command for
> the generated menu (which currently just gives an empty menu for
> me).
> 
> Regards, Andreas
> 

Hi,

I didn't test your patches :-(

Some comments about the coding style.

1. The "if{" should be "if {"
2. The "else" in patch 1 should include the bracket "{".

+                   pldata->ptr[0] = '\0';
+               }
+               else
+                   pldata->ptr = wrealloc(pldata->ptr,

Cheers,
kix
-- 
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/


-- 
To unsubscribe, send mail to [email protected].

Reply via email to