On Thu, 31 Jan 2013 at 22:44:31 +0100, Andreas Bierfert wrote:
> Subject: [PATCH 2/3] Add OPEN_PLMENU option to parse command generated
> proplist style menus
>
> This patch adds the OPEN_PLMENU options which behaves similar to OPEN_MENU but
> can be used to parse command generated proplists. This can be used e.g. in
> conjunction with wmmenugen like:
> (
> "Generated PL Submenu",
> OPEN_PLMENU,
> "|| find /usr/share/applications -type f -name '*desktop' | xargs
> wmmenugen -parser:xdg"
> )
Thanks!
But this patch generates some warnings here:
CC resources.o
CC rootmenu.o
CC screen.o
rootmenu.c: In function ‘constructPLMenuFromPipe’:
rootmenu.c:721:3: warning: ‘return’ with no value, in function returning
non-void [-Wreturn-type]
rootmenu.c:746:2: warning: label ‘finish’ defined but not used [-Wunused-label]
rootmenu.c: In function ‘addMenuEntry’:
rootmenu.c:860:4: warning: passing argument 4 of ‘wMenuInsertCallback’ from
incompatible pointer type [enabled by default]
In file included from window.h:29:0,
from actions.h:24,
from rootmenu.c:42:
menu.h:111:13: note: expected ‘void (*)(struct WMenu *, struct WMenuEntry *)’
but argument is of type ‘void * (*)(struct WMenu *, struct WMenuEntry *)’
CC session.o
CC shutdown.o
The warning about the return is strange since the function is static void,
but the one about the label is correct.
Can you take a look?
By the way, the warnings are easy to spot with --enable-silent-rules passed
to 'configure' and compiling with 'make -s'. I should make this the default
so that everybody can get a chance to be annoyed by the warnings and
address them :-)
--
To unsubscribe, send mail to [email protected].
