On Thu, 4 Apr 2013, Daniel Déchelotte wrote:
Before this patch, if the Dock/Clip is in the screen bottom, and clip
to
show the menu in the bottom area, the menu is hidden outside the
screen.
Sorry for chiming in without fully understanding the bug and the fix,
but IIUC, wMenuMapAt() is given the "preferred" (x,y) coordinates where
to display the menu. Then it is responsible for overriding them if the
menu would appear off-screen and if asked by the user's preferences.
IOW, the logic of "we are too close to the border, let's move a bit"
should happen in wMenuMapAt, and only if the appropriate preference is
set. No?
As someone who uses the "appropriate preference" (Scroll off screen menus
is on) tried it and seems that it works all right for app icons at the
bottom of the screen but for docked app icons the menus are indeed
inaccessible if the pointer is within two pixels of the bottom of the
screen. These two pixels seem to also exist when menus are displayed
elsewhere: App icon menus are open with the pointer touching their top
(moving down one pixel selects the first menu item) while for
docked/clipped appicons there's a two pixel gap between the pointer and
the menu (only the third pixel down will select the menu). This might be
something to do with this bug but I don't know where does it come from.
Regards,
BALATON Zoltan
