On Thu, 4 Apr 2013, Rodolfo García Peñas wrote:
Remove the "+ 2" is ok, but I think we should thing in change the things to re-use the same functions.
You can think of that but that's beyond fixing this bug.
Anyway, if we remove the "+ 2" (line 3222), the problem with the Clip (probably Dock) is gone. But, the menu is hidden, you must move the mouse down to see it (you cannot see nothing).
That's how it works if Scroll off screen menus option is turned on for app icons too and that's how it's supposed to work.
In my patch, the menu is moved up 20 pixels, then, the first menú entry is painted in the screen and you know that the menu is there, partially hidden, but there.
While this may seem like a good idea it isn't necessarily so because the rationale behind the scroll off screen menus feature is that menus should behave the same independent of screen position (to allow to build "muscle memory" and know that a certain down move will activate the same menu item everywhere instead of having to find it and aim at it constantly). Thus when using this option you're supposed to know the menu is there and don't need visual clues for that. (That said the current implementation is not perfect because the menu scrolls up too fast so it's still not the same amount of downward move to select menu entries as elswhere on the screen but that's probably another bug. Maybe the menu is now scrolled if the pointer is at the screen edge but should only be scrolled for downward move events instead. I didn't check if this theory is true though.)
Regards, BALATON Zoltan
