From: Christophe CURIS <[email protected]>

----- Carlos R. Mafra <[email protected]> a �crit :
> On Sun, 29 Sep 2013 at 13:22:54 +0200, Christophe wrote:
> > From: Christophe CURIS <[email protected]>
> > 
> > [...]
> > +/* Mouse cursors */
> > +typedef enum {
> > +   WCUR_DEFAULT            = 0,
> > +   WCUR_NORMAL             = 0,
> > +   WCUR_MOVE               = 1,
> > +   WCUR_RESIZE             = 2,
> > +   WCUR_TOPLEFTRESIZE      = 3,
> > +   WCUR_TOPRIGHTRESIZE     = 4,
> > +   WCUR_BOTTOMLEFTRESIZE   = 5,
> > +   WCUR_BOTTOMRIGHTRESIZE  = 6,
> > +   WCUR_VERTICALRESIZE     = 7,
> > +   WCUR_HORIZONRESIZE      = 8,
> > +   WCUR_WAIT               = 9,
> > +   WCUR_ARROW              = 10,
> > +   WCUR_QUESTION           = 11,
> > +   WCUR_TEXT               = 12,
> > +   WCUR_SELECT             = 13,
> > +   WCUR_ROOT               = 14,
> > +   WCUR_EMPTY              = 15,
> > +
> > +   /* Count of the number of cursors defined */
> > +   WCUR_LAST               = 16
> > +} w_cursor;
> 
> 
> Is it really necessary to add the explicit numbers too?
> 
> I'm remembering the patch below which used 'enum' in order to
> avoid having the explicit numbers being #define'd. 
> 
> If one wants to add something in the middle then it's much better
> without the explicit numbers.
> 
> What am I missing?

Nothing!

I suppose my initial guess was to keep the same value
because the configuration file may have used the numbers
directly, but I have checked and it is not the case, the
config uses explicit names, this enum is purely internal
to wmaker.

So you'll find a patch you may use to replace the previous
one if you wish to get rid of them.


-- 
To unsubscribe, send mail to [email protected].

Reply via email to