From: Christophe CURIS <[email protected]>

----- Rodolfo Garc�a Pe�as a �crit :
> On Sun, 29 Sep 2013, Christophe escribi�:
> 
> > From: Christophe CURIS
> > 
> > +typedef enum {
> > +
> > +   [...]
> > +
> > +   /* Alias for the Default cursor */
> > +   WCUR_DEFAULT = WCUR_NORMAL
> > +} w_cursor;
> 
> I don't like this, IMO, the WCUR_DEFAULT definition should be out of the 
> enum, because is an enum.
> 

Personally, I prefer to place it in the enum, because it is one value applicable
for the type being defined, and also because #define are just a hack inherited
from the origin of C, which should be avoided when not necessary for code
maintainability.

But for this very specific case, I believe the proper solution was suggested by
yourself some patches ago, which I re-propose in the next patch...


-- 
To unsubscribe, send mail to [email protected].

Reply via email to