On Fri, 7 Mar 2014 at 8:46:33 +0800, David Maciejak wrote: > This patch is used to scale image to fit in the icon preview panel. >
Thanks for the patch, I think I once noticed this problem when setting a high-res icon to be used. That leads to my small request :-) Can you be a little more verbose in your commit message? Just one paragraph is enough, most of the times. What I usually require from contributors (though this is not mandatory people are kind enough to comply) is to invest a few minutes trying to explain what led you to make the patch. Do not assume that everybody is an expert in wmaker, try to explain what was the behaviour you noticed (icon does not fit in the 64x64 square) when trying to do something (eg setting an icon image through the Inspector panel from the Attributes menu). Just plain words that people can immediately relate to. The motivation for the patch is very important! Furthermore, I notice that the patch you attach does not have a commit message at all. So far I've been applying it and doing a 'git commit --amend' to insert some words (that I usually copy & paste from your email). That does not scale though. When you create your patch in your own machine, please try to make an effort to write some description after issuing: 'git commit -a'. Your favorite editor will open, that's when you should write the commit message. After that, when you generate the patch with 'git format-patch HEAD~1' the commit log will be there, and that's the thing you should attach. I'm sorry for the pedantism, but the wmaker history should be well documented in the repository. I applied this patch already though. -- To unsubscribe, send mail to [email protected].
