On Fri, Mar 7, 2014 at 7:13 PM, Carlos R. Mafra <[email protected]> wrote: > On Fri, 7 Mar 2014 at 8:46:33 +0800, David Maciejak wrote: >> This patch is used to scale image to fit in the icon preview panel. >> > > Thanks for the patch, I think I once noticed this problem when setting > a high-res icon to be used. > > That leads to my small request :-) > > Can you be a little more verbose in your commit message? Just one > paragraph is enough, most of the times. > > What I usually require from contributors (though this is not mandatory > people are kind enough to comply) is to invest a few minutes trying > to explain what led you to make the patch. > > Do not assume that everybody is an expert in wmaker, try to explain > what was the behaviour you noticed (icon does not fit in the 64x64 square) > when trying to do something (eg setting an icon image through the > Inspector panel from the Attributes menu). Just plain words that people > can immediately relate to. The motivation for the patch is very important! > > Furthermore, I notice that the patch you attach does not have a commit > message at all. So far I've been applying it and doing a 'git commit --amend' > to insert some words (that I usually copy & paste from your email). That > does not scale though. >
i am usually using -m, but ok i will try to add longer msg. regards, david -- To unsubscribe, send mail to [email protected].
