Hi John,

I did not run the the patch I submitted against AllWodenTests. However
I wrote some test cases for OMWSDLFactory and the OMWSDLReader. And
those tests passed without any complaint :).
I guess the reason the tests failed for you is because the
readWSDL(String wsdlURI, ErrorHandler errorHandler) method is not
implemented in the OMWSDLReader. That method returns a null
DescriptionElement at the moment, and explains the test failures
you've got. The patch I submitted is sort of like a proof of concept
and only the readWSDL(String wsdlURL) method is implemented there.
That method seems to be working fine and returns a valid
DescriptionElement.

I will implement the remaining readWSDL signatures and send a patch
soon. But, in the mean time if you want, I could send in those test
cases I've written. But they were implemented separately from the
woden test suite. Anyway, it's just a matter of rewriting the  DOM
test cases. So, would it be okay to integrate them into the woden test
suite? If so, can you suggest a naming convention to be used for the
OM based tests?

Thanks for reviewing the patch and apologies for not including the
Apache copyright boilerplate text. I will make sure to include it next
time I send a patch :)

Regards,
Oshani

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to