Oops! I have only sent this mail to Jeremy and not to woden-dev.
---------- Forwarded message ---------- From: Oshani Seneviratne <[EMAIL PROTECTED]> Date: Jul 4, 2006 11:05 PM Subject: Re: OM / StAX implementation To: Jeremy Hughes <[EMAIL PROTECTED]> Hi Jeremy, On 7/4/06, Jeremy Hughes <[EMAIL PROTECTED]> wrote:
Are you planning on creating some unit tests.
I have already written some unit tests, and I'm more than happy to contribute it.
It would be great if we could run all the existing unit tests through the OM/AXIOM code - ie run them once for DOM and once for OM/AXIOM.
Did you mean writing separate test cases for OM, or are you thinking of some other abstraction? If it's the former, it is almost done :). In most of the cases it was just a matter of rewriting those existing test cases to pass the factory impl name to obtain the OMWSDLFactory. I can send in those test cases after integrating them into the Woden test suite. However, if there's a better way, please advice. Also, about the concern regarding the users of DOMWSDLReader having to have Axiom and Stax jars, etc... : Well, how about separating the two implementations, so that the users will only need the jars that are required for their preferred parser? This might involve the OM stuff to be moved into a different package. But, if total separation is needed I guess there would be some code duplicated! Any thoughts on this? Thanks and regards, Oshani. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
