Hi, comments in-line.
On 7/7/06, Oshani Seneviratne <[EMAIL PROTECTED]> wrote:
Hi devs,
I have added some tests which are similar to the tests that are there
in the DOM implementation.
These include
org.apache.woden.tests.AllWodenTestsOM
org.apache.woden.OMWSDLFactoryTest
org.apache.woden.OMWSDLReaderTest
org.apache.woden.tests.OMW3CTestSuiteTest
org.apache.woden.wsdl20.xml.OMServiceElementTest
org.apache.woden.wsdl20.xml.OMEndpointElementTest
"WeathSvc-1G W3C test" - see [1], would fail if you do not have the
latest XMLSchema jars. So, I have commented it out.
I've updated Woden to 1.0.3, is that good enough?
(FYI:There was a fault in the way XMLSchema handled schema elements,
that have references to other schema elements. So, pretty strangely it
showed up for the OM parser, whereas it was okay with the DOM version.
But it has been fixed now, so all the tests should be working fine
with the latest jars)
I have attached the patch for all these tests at [2].
Also, I made some modifications to the OMWSDLReader. The changes include:
1. Addition of the methods readWSDL(uri, errorHandler), parseImport,
parseInclude, and getWSDLFromLocation
&
2.Changes to the way schema is handled with OM in the parseSchemaInline method.
This patch is attached at [3]. You would need to have this in order to
run all the tests successfully.
And to share some statistics with you... I was able to run the
OMW3CTestSuiteTest in under 90s most of the time, whereas its
counterpart for the DOM implementation - the W3CTestSuiteTest, took
between 900s - 2000s! Pretty impressive ha? :)
Wow that sounds cool. But it only takes me 40 secs or so to run
W3CTestSuiteTest today. How many times were you running the test suite
to get these figures? If only once then perhaps there is another
factor involved - perhaps network speed?
So, I would really appreciate if someone can review and apply these 2 patches.
I'll take a look today. Thanks for this!!
Thanks and regards,
Oshani.
[1]org.apache.woden.tests.AllWodenTestsOM#testWeathSvc1G()
[2]http://issues.apache.org/jira/secure/attachment/12336436/TestsForOMParser.patch
[3]http://issues.apache.org/jira/secure/attachment/12336440/OMWSDLReader-additions.patch
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
