Hi Jeremy,

I'm terribly sorry for the trouble that you had to undergo in applying
my 2 previous patches! And also, thanks a lot for pointing out the
correct way of submitting patches.

I have attached a new patch at [1], which you could apply at the Woden
root. Please disregard those 2 earlier patches, i.e.
'TestsForOMParser.patch' and 'OMWSDLReader-additions.patch' that I
have attached with WODEN-37.

I documented all the changes that are there with the new patch at [2].
Basically I have modified the classpath, project.properties and
changed the code & the ant scripts so that you would be able to run
tests for both DOM and StAX/OM parsers.

So, after applying the patch you can run:
'ant runTestsDOM' to see tests for DOM,
'ant runTestsOM' to see tests for StAX/OM, and
'ant runTests' to see tests for both.

[1] 
http://issues.apache.org/jira/secure/attachment/12336594/TestsAndAdditions.patch
[2]
http://issues.apache.org/jira/browse/WODEN-37#action_12420090

Thanks and Regards,
Oshani.



On 7/8/06, Jeremy Hughes <[EMAIL PROTECTED]> wrote:
Hi Oshani, thanks for your patches. I started to apply them, but I
came up against a few problems. Firstly the TestsForOMParser.patch was
created when you were in the test/org/apache/woden directory. This I
could workaround - it is normal (although I have to admit we haven't
documented this on the Woden site) to create the patch while in the
project root dir. The OMWSDLReader-additions.patch had a similar
problem. Anyway, I worked around this.

The main issue is that I can't run the tests without making changes to
the classpath and I ran out of time here figuring it out. It would be
great if I could take your patch and just like the in the
contributors' FAQ [1], run the 'patch' command from the command line
in the root dir of Woden. Then if I do 'ant runTests' all the new
tests should get run as well as the old ones - and of course for all
the tests to pass :-)

[1] http://www.apache.org/dev/contributors.html#patches

Many thanks,
Jeremy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to