On 02/09/2012 01:08 PM, Scott Wilson wrote:
On 9 Feb 2012, at 11:51, Ate Douma wrote:
I'm trying to review the current wookie trunk on LICENSE and NOTICE
requirements for the next release.
First question I have is: how do I 'build' a release binary?
From ant -p I don't see a build target which should do that.
Try:
ant build-release-all
This creates src, war and standalone release packages in the release folder
Thanks, that works!
Weird that ant -p doesn't report that as target, but I'm not accustomed to use
ant (in a long time) anymore, so probably I shouldn't expect that anyway.
Makes it even more needed to have extensive developer and release-management
documentation IMO.
To be able to properly review what will end up in the binary release, I need to
be able to build that myself, or have to wait until a candidate is prepared by
others. I'd like to do it myself :)
Indeed :-)
It would also be nice if a release-management kind of documentation could be
published on the website, kind of similar to what we have for Rave [1].
+1
As a start I looked briefly at the root NOTICE file which raises a few
suggestions and questions already:
- Bubbles.wgt notice
I looked the provided url up but couldn't find any license or notice whatsoever
for inclusion/usage of this widget, and neither does the .wgt has anything
embedded. Where did this *required* notice come from (note: only *required*
notices should be added to the NOTICE file)
The widget isn't published on Opera any more, it was replaced by a later
version that doesn't seem to have any associated license info, so I've kept the
older version I took from Opera which did contain the original license and
notices we've retained, rather than try and update it.
Got it.
- many/most of the other notices seems to be for MIT/BSD licensed stuff
Those should not need notices, unless (extra) explicitly required and/or coming
with a NOTICE (file) of their own. In general, if for these products their
license (with copyright statement) is included in our LICENSE file, there is no
need to also add a notice in the NOTICE file. AFAIK the /LICENSE file already
takes care of that properly, +1 on that.
In general, the NOTICE file should not be used for providing friendly credits.
This file has a legal purpose only.
If we want to give friendly but non-required credits, the README file
can/should be used for that instead.
Anything we add to our NOTICE (required or not) we force upon our downstream
users to keep as specified by our AS 2.0 license section 4d.
This is why more recently there is more attention for making sure we only put
really required entries in the NOTICE file, to lessen the burden for our
downstream users.
Thanks Ate, I did wonder about that as I was following the discussions about
the Rave NOTICE file. I'll create a Jira issue for it now.
Great. And I see you're already cleaning up :)
I'll pick up further reviewing sometime later but its getting to look good.
Template filtering (WOOKIE-314) also added, good stuff!
Ate
Ate
