I have updated the patch and it now works when JS is disabled, I would love some feedback on that
Leo,, On 9/11/09, Leo germani <[email protected]> wrote: > hmm. No. Good to know, Ill work on that... > > On Fri, Sep 11, 2009 at 6:31 AM, scribu <[email protected]> wrote: > >> Does your patch work if the user has js disabled? That's a requirement >> for >> all the WP administration. >> >> >> On Fri, Sep 11, 2009 at 12:49 AM, Leo germani <[email protected]> >> wrote: >> >> > nobody? >> > >> > On Fri, Sep 4, 2009 at 9:51 AM, Leo germani <[email protected]> >> wrote: >> > >> > > hey, >> > > >> > > sorry for that, there was actually a javascript missing.. the patch >> > > is >> > fine >> > > now.. thanks for the testing >> > > >> > > >> > > On Fri, Sep 4, 2009 at 9:33 AM, Leo germani <[email protected]> >> > wrote: >> > > >> > >> No. the patch is fine... I tested it here apllying on the top of the >> > trunk >> > >> of wordpress repository. >> > >> >> > >> The Add button wont do anything only if you: >> > >> >> > >> . leave the name field blank >> > >> . use one of the protected names (Thumbnail, Medium, Large, Full >> > >> size) >> > >> >> > >> Leo,, >> > >> >> > >> >> > >> On Fri, Sep 4, 2009 at 2:15 AM, John Blackbourn < >> > [email protected] <johnbillion%[email protected]> < >> johnbillion%[email protected] <johnbillion%[email protected]>>< >> > johnbillion%[email protected] <johnbillion%[email protected]> < >> johnbillion%[email protected] <johnbillion%[email protected]>>> >> > >> > wrote: >> > >> >> > >>> This is a really good idea. +1 from me. >> > >>> >> > >>> Unfortunately your current patch isn't working for me. Clicking the >> > >>> 'Add' link does nothing. Have you missed out some Javscript in your >> > >>> patch? >> > >>> >> > >>> John. >> > >>> >> > >>> 2009/9/4 Leo germani <[email protected]>: >> > >>> > hi there, >> > >>> > >> > >>> > Ive just commited this patch and would be nice to have some >> feedback. >> > >>> > >> > >>> > http://core.trac.wordpress.org/ticket/8599 >> > >>> > >> > >>> > Apply the patch and go to Settings > Media. You will be able to >> > >>> > set >> > as >> > >>> many >> > >>> > sizes as you like. then upload some images and enjoy >> > >>> > >> > >>> > then >> > >>> > >> > >>> > cheers >> > >>> > >> > >>> > Leo,, >> > >>> > >> > >>> > -- >> > >>> > leogermani.pirex.com.br >> > >>> > leogermani.estudiolivre.org >> > >>> > _______________________________________________ >> > >>> > wp-testers mailing list >> > >>> > [email protected] >> > >>> > http://lists.automattic.com/mailman/listinfo/wp-testers >> > >>> > >> > >>> _______________________________________________ >> > >>> wp-testers mailing list >> > >>> [email protected] >> > >>> http://lists.automattic.com/mailman/listinfo/wp-testers >> > >>> >> > >> >> > >> >> > >> >> > >> -- >> > >> leogermani.pirex.com.br >> > >> leogermani.estudiolivre.org >> > >> >> > > >> > > >> > > >> > > -- >> > > leogermani.pirex.com.br >> > > leogermani.estudiolivre.org >> > > >> > >> > >> > >> > -- >> > leogermani.pirex.com.br >> > leogermani.estudiolivre.org >> > _______________________________________________ >> > wp-testers mailing list >> > [email protected] >> > http://lists.automattic.com/mailman/listinfo/wp-testers >> > >> >> >> >> -- >> http://scribu.net >> _______________________________________________ >> wp-testers mailing list >> [email protected] >> http://lists.automattic.com/mailman/listinfo/wp-testers >> > > > > -- > leogermani.pirex.com.br > leogermani.estudiolivre.org > -- leogermani.pirex.com.br leogermani.estudiolivre.org _______________________________________________ wp-testers mailing list [email protected] http://lists.automattic.com/mailman/listinfo/wp-testers
