http://bugzilla.wpkg.org/show_bug.cgi?id=79
--- Comment #34 from Rainer Meier <[EMAIL PROTECTED]> 2007-11-12 15:19:44 --- Leon: You're right that using a log file template which includes minutes/seconds can pollute the log directory. That's why logrotate can be used. Additionally that was exactly the intention behind using "overwriting" instead of "appending". Personally I don't see a reason to keep an installation history within the log files at all. Most people (like me) will use the log file for remote-debugging and checking if the last run on any client yielded any error message. By using log appending and rotating I might even get errors which are not valid any more since a long time so you need to filter by timestamp (last installation?) as well. Since WPKG verifies _all_ packages at each run I do not have to care about history. I just need to check if the last execution was correct. Additionally the log file template can be changed dynamically (also temporarily) within config.xml on the server. It looks like you're a windows-only user. So let me explain why your changes require special permissions on the directory. You use delete and rename within your code. Both are actually operations on the directory. Renaming a file just means to change the file descriptor within the directory inode entry. Deleting a file requires modification on the directory inode entries as well. Writing to the same file does not require operations on the directory level. So if you do not give write access to users on the log directory (but on pre-created files instead) your modification will fail. Another side-note about dependency installation. This is a debug statement and yes wpkg executes the dependency installation for each package (recursively) even if the package does not have any dependencies (since the dependency install function will exactly check this). So it is done on purpose that each package is installed in three steps: - prepare installation - install dependencies - install package itself Anyway, as I stated: The current state is quite stable. I will leave it as it is. Your patch for log rotation is still there for later re-usage. Probably it can be included within the patches directory of the next release (along with some other modifications). -- Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ------------------------------------------------------- Easy Software Deployment >> http://wpkg.org _______________________________________________ wpkg-users mailing list wpkg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wpkg-users
