> Just got  my latest project to validate XHTML Strict, and just wanted any
> helpful criticism and also to see if any problems with any Browsers and
> Operating Systems .
>
> http://www.clock-this.co.uk/

Pro:
Looks nice

Cons:
  - increasing text size messes thing up (at least in Safari/Mac)

  - Inline styles (style="…") – bad idea. CSS is about seperation
content and presentation, so inline styles should be avoided.

  - This is really bad:
<div><p/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><br/><img
src="img/quote2.jpg" alt=""/></div>.
   Decorative images shouldn't be in you XHTML code, they belong in
CSS. Also, use CSS to position them.

  - This is especially bad: <div
onmouseover="this.style.background='transparent';
this.style.color='#93278e';"
onmouseout="this.style.background='transparent';
this.style.color='#606060';" class="txtnavbaritem" style="left: 11px;
top: 11px; width: 109px; height: 18px; background: transparent;
font-family: Microsoft Sans Serif; font-size: 11px; color: #606060;
opacity: 1.000000; filter: alpha(opacity=100);
text-decoration:none;padding-left: 10px; font-weight:bold;"><a
style="text-decoration:none"
href="http://www.clock-this.co.uk/tick-talk.php";>Tick Talk</a></div>
 Jus use CSS for effect: define how your links look with a:link {…},
and then define how they look while mouse is over them with a:hover
{…} That way you will avoid needles
code repetition, unnecessary Javascript and inline styles, code will
be much more compact and easier to read/maintain.

I think this will do for starters, did not dig deeper.

Regards,
Rimantas
--
http://rimantas.com/


*******************************************************************
List Guidelines: http://webstandardsgroup.org/mail/guidelines.cfm
Unsubscribe: http://webstandardsgroup.org/join/unsubscribe.cfm
Help: memberh...@webstandardsgroup.org
*******************************************************************

Reply via email to