Hi Ton,

I have committed this along with a similar change to ensure that changing the font does the same.

Thanks for the research, testing and patch.

73
Bill
G4WJS.

On 10/04/2015 17:06, Bill Somerville wrote:
On 10/04/2015 16:44, Ton PA0TBR wrote:
Hello Bill,
Hi Ton,

I added 2 lines is my local copy to ensure left alignment of the Band Activity window. When a decode string exceeds the available width of the view port, the scroll bar appears, but the window is not automatically scrolled to the right anymore.
So the Time info remains visible.
When the horizontal and / or vertical scroll bar is used and new decodes are added, the text is added to the bottom (as before) and the text is visible from 1st character of the last line. I was puzzled that the move to StartOfLine did not work and found by trial and error that it would do the job if preceded by a move Up (1 line).
Well done for finding the magic incantation for cursor positioning. I do not fully understand the move position operations in this situation and I think the strange behaviour is something to do with the document contents being a table.

I will try a few more tests with your proposed change but I think it is OK, I will commit it shortly.

void  DisplayText::_insertText(const  QString  text,  const  QString  bg)
{
     QString  s  =  "<table  border=0  cellspacing=0  width=100%><tr><td  
bgcolor=\""  +
       bg  +  "\"><pre>"  +  text.trimmed  ()  +  "</pre></td></tr></table>";
     moveCursor  (QTextCursor::End);
     append  (s);
     moveCursor  (QTextCursor::End);
     moveCursor  (QTextCursor::Up);                //  pa0tbr
     moveCursor  (QTextCursor::StartOfLine);       //  pa0tbr
}

It solved my issue.

73,
Ton PA0TBR

73
Bill
G4WJS.

On Wed, Apr 8, 2015 at 6:02 PM, Ton PA0TBR <[email protected] <mailto:[email protected]>> wrote:

    Hello Bill,

    Thanks again for a fine explanation.
    I had a look at the country list and noted that some 53 country
    names are 'too long'.
    It won't be easy to abbreviate these country names, such that it
    remains clear for everybody.

    Leaving the view port scrolled to the far left looks like the way
    to go because then the user can scroll to see the full name.
    I didn't have much time yet but I like to explore that a bit
    further. I let you know if I succeed or not.

    73,
    Ton PA0TBR





        Date: Tue, 07 Apr 2015 16:57:12 +0100
        From: Bill Somerville <[email protected]
        <mailto:[email protected]>>
        Subject: Re: [wsjt-devel] Horizontal scroll bar in WSJT-X Band
        To: [email protected]
        <mailto:[email protected]>
        Message-ID: <[email protected]
        <mailto:[email protected]>>
        Content-Type: text/plain; charset="windows-1252"

        On 07/04/2015 16:30, Ton PA0TBR wrote:
        > Hello Bill,
        Hi Ton,
        >
        > Thanks for your quick answer and the work you have been
        doing to
        > reduce the length.
        >
        > Where in the source can I find the country list?
        The country list is taken from a standard CTY.DAT file (it is
        embedded
        in the application) which you can override with a user
        version if you wish.

        The extra abbreviation as it stands now is:

                 // do some obvious abbreviations
                 countryName.replace ("Islands", "Is.");
                 countryName.replace ("Island", "Is.");
                 countryName.replace ("North ", "N. ");
                 countryName.replace ("Northern ", "N. ");
                 countryName.replace ("South ", "S. ");
                 countryName.replace ("East ", "E. ");
                 countryName.replace ("Eastern ", "E. ");
                 countryName.replace ("West ", "W. ");
                 countryName.replace ("Western ", "W. ");
                 countryName.replace ("Central ", "C. ");
                 countryName.replace (" and ", " & ");
                 countryName.replace ("Republic", "Rep.");
                 countryName.replace ("United States", "U.S.A.");
                 countryName.replace ("Fed. Rep. of ", "");
                 countryName.replace ("French ", "Fr.");
                 countryName.replace ("Asiatic", "AS");
                 countryName.replace ("European", "EU");
                 countryName.replace ("African", "AF");

        which is in displaytext.cpp. They seemed to be good choices after
        reviewing a current CTY.DAT file. More similar unambiguous
        replacement
        could be added.
        >
        > The position of the heading is not so important, but when I
        look at
        > decoded callsigns, I like to see when the decode took place.
        > Enlarging the window is no option for me, running 2
        instances, logbook
        > and PowerSDR, my monitors are crowded as it is.
        >
        > Maybe an option to allow truncation? It's probably not that
        easy to
        > know what will fit, with the different font sizes, fonts
        and environments.
        You are correct that is potentially a complex calculation, but my
        problem with truncation is that there is no indication that
        truncation
        has happened, the horizontal scroll bar is the idiomatic way of
        indicating truncation of a text field. I did have a brief
        attempt at
        ensuring that the scroll view port is left scrolled as far to
        the left
        as possible after new decodes but hit some issues with
        implementation.
        If you think this would help I can have another go at that.

        I have recently improved the ability to set the decoded text
        font fixing
        some defects. You may find that selecting smaller font for
        decoded text
        is your best option.

        I have plans to make the activity windows into proper table
        views as the
        current implementation using a text edit widget is not the
        most suitable
        for displaying this sort of information. Text edits provide a
        vast
        number of features that we don't need but complicate
        populating and
        manipulating them a great deal. A table view will allow user
        setting of
        column width and even hiding columns. A table view would even
        allow
        wrapping within a column if we wished or a tool tip to
        display extra
        information about the decode line.

        Another option with a table view could be to have only a
        single activity
        window with a "filter" button that filters it to decodes and
        Tx messages
        on the current Rx frequency i.e. the same window could then
        double as a
        band activity and on frequency activity monitor.
        >
        > 73,
        > Ton PA0TBR
        >
        73
        Bill
        G4WJS.


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to