On 07/07/2016 22:50, Black Michael wrote:
I decided to take a look at this and I think this is all that's needed
to add the watchdog timeout to the UDP packet.
I believe you had said just adding a value to the end of the packet
wasn't a version change.
Hi Mike,
as far as it goes, that is mostly correct. A few issues and suggestions:
You should initialize all member variables, that do not have a sensible
default initialization, in the constructor initialization list but see
below.
I'm not sure a new MainWindow class member variable is necessary or
wise, it may be better to make the new flag in the UDP status message
the value of the following expression:
(!m_mode.startsWith ("WSPR") && m_config.watchdog() && m_repeatMsg >=
m_config.watchdog ())
that way there should be no ambiguity with the flag value and
statusUpdate() will always do the right thing wherever it is called. A
single shot implementation is not really compatible with UDP as the
protocol should be considered unreliable.
Your patch contains unrelated changes.
You should also adjust the implementation of the MessageServer class to
extract the new field. This also means that you need to adjust
UDPExamples/UDPDaemon.cpp and the relevant message_aggregator classes. I
have also been adding some sort of exercising of each message to
message_aggregator so that they can be easily tested and verified. For
example you might highlight a status bar field for the ClientWidget that
is connected to the timed out WSJT-X instance, see
ClientWidget::update_status() and how it uses Qt dynamic properties and
the application stylesheet (UDPExamples/qss/default.qss) to show state
changes like this.
73
Bill
G4WJS.
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
