On 27/11/2019 16:59, Bill Somerville wrote:
The next step is probably to try and reproduce using the Hamlib rigctl command line tool. Creating a debug build of Hamlib is fairly straightforward. Debugging with an instance of WSJT-X is somewhat more complex. There is a build of rigctl (called rigctl-wsjtx) packaged with WSJT-X, try using that for starters, it looks this crash is while opening the rig connection, the prior one was later in the process setting the rig's VFO frequency.

Hi Karl Heinz,

looking at the flrig back end in Hamlib I see one possible cause of thisĀ  issue, it uses the C library function strtok() which is not re-entrant and is thread-unsafe on non-Windows platforms. That could easily screw up where it is used in WSJT-X which is multi-threaded. Bottom line is that Hamlib advertises as a thread safe library so it should not be using functions like strtok(), strtok_r() could be used instead, although IMHO all variants of strtok() are so clumsy that a different way of breaking up C-strings containing delimiters is almost always the best solution.

I know that Mike, W9MDB, is familiar with the flrig Hamlib interface, perhaps he could look at a patch to remove the strtok() calls.

73
Bill
G4WJS.



_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel

Reply via email to