Thanks to the pointers Mickael. I imported that project and ran the tests from Eclipse. Just running the tests on master without my patch for 432978<https://bugs.eclipse.org/bugs/show_bug.cgi?id=432978>I get 142 errors. Perhaps that is because of something in my environment. But at least when I applied my patch it didn't create any new errors :)
On Fri, Apr 18, 2014 at 3:23 PM, Mickael Istria <[email protected]> wrote: > On 04/18/2014 04:36 AM, Greg Amerson wrote: > > Hello wtp-dev list, > > I have a bug entry that I reported here: > https://bugs.eclipse.org/bugs/show_bug.cgi?id=432978 > > The JSP editor is having some problems with the taglibs produced by the > Liferay project and I've investigated it and have proposed a potential fix > to the JSPTranslator in the referenced bugzilla but I'd like to help out > the committers by first running the jst.jsp.core.tests to see if my patch > is breaking anything there. But I'm unsure of how to execute those unit > tests outside of the eclipse.org infrastructure. Is there a document > somewhere that describes how to do that? I've clicked a few links on the > webtools/** pages but haven't seen what looks like a current doc for that. > > AFAIK, tests by themselves don't have any dependency on > eclipse.orgarchitecture. So you should be able to try them from your IDE by > setting up > a good enough target-platform, importing projects you want to test + the > test and use PDE "Run As > JUnit Plugin Test" context menu. > > I don't know the status of this specific WTP component, but as part of > https://bugs.eclipse.org/bugs/show_bug.cgi?id=425148 , there is an > ongoing effort to run tests easily with Maven. > So I suggest you first try: > $ mvn clean verify -Pbuild-individual-bundles -DskipTests=false > -Dmaven.test.skip=false > run this from the root of Git repository, to see what happens. > * mvn clean verify means "please build and test" > * -Pbuild-individual-bundles means "please use dependencies from latest > webtools integration site" (cf > https://git.eclipse.org/c/webtools/webtools.releng.aggregator.git/tree/wtp-parent/pom.xml#n376) > * -DskipTests=false -Dmaven.test.skip=false are there to make sure tests > are not disabled (they should be optional since those are the default > values, but it's better being sure) > If you see any issue with that, I guess you can report it on bug 425148 or > one of its children bugs. > > For the other Ant-based build, I don't know much how to help you. I > believe if you have the tests working with both PDE and Maven, you don't > have to worry much about it. > > HTH > -- > Mickael Istria > Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools> > My blog <http://mickaelistria.wordpress.com> - My > Tweets<http://twitter.com/mickaelistria> > > _______________________________________________ > wtp-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/wtp-dev > > -- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com
_______________________________________________ wtp-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/wtp-dev
