I've added the unit test now, so how do I get a committer to have a look? https://bugs.eclipse.org/bugs/show_bug.cgi?id=432978
I'd like to avoid the [hotbug] request if I can :) On Sat, Apr 19, 2014 at 12:41 AM, Greg Amerson <[email protected]>wrote: > On second look, perhaps it isn't a OS bias but rather a "do you have git > configured correctly?" check where they were making sure that the test > source files didn't have any CRLF or CR's in them (\n's only allowed). > > Regardless, thanks for the help I was able to my unit test written and > posted to the bug <https://bugs.eclipse.org/bugs/show_bug.cgi?id=432978>. > > > > On Fri, Apr 18, 2014 at 5:29 PM, Mickael Istria <[email protected]>wrote: > >> On 04/18/2014 11:21 AM, Greg Amerson wrote: >> >> Actually I disabled the UI thread, maybe I should bring it back. >> >> If those tests directly manipulate Shells and Widgets without using a >> Display.syncExec, a Display.asyncExec or a UIJob, then they most likely >> need to run inside UI thread. >> At least, that's definitely worth a try. >> >> >> After looking at a few of the test failures it appears to be assuming >> linux is the OS which I'm on windows right now, so that could likely be the >> the source of many failures. >> >> How do they assume Linux is the OS ? I believe the WTP contributors >> generally try to avoid that, so it would be bit surprising. >> If those tests actually only work on Linux, then I guess a patch helping >> those tests to run on Windows as well would be highly welcome. >> >> >> -- >> Mickael Istria >> Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools> >> My blog <http://mickaelistria.wordpress.com> - My >> Tweets<http://twitter.com/mickaelistria> >> >> _______________________________________________ >> wtp-dev mailing list >> [email protected] >> https://dev.eclipse.org/mailman/listinfo/wtp-dev >> >> > > > -- > Greg Amerson > Liferay Developer Tools > Liferay, Inc. www.liferay.com > -- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com
_______________________________________________ wtp-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/wtp-dev
