Yeah I pushed it to master. Let me know if that is correct way to do. I am having hard time here working with GIT.
- Angrez On Sat, Nov 14, 2009 at 1:02 AM, Bret Pettichord <[email protected]>wrote: > No they didn't. It looks like you just pushed the close_all method to > master. > > Bret > > > On Fri, Nov 13, 2009 at 5:55 AM, Angrez Singh <[email protected]> wrote: > >> Bret, >> >> Did any of these changes made to 1.6.5 release? >> >> - Angrez >> >> >> On Thu, Oct 15, 2009 at 9:50 AM, Bret Pettichord <[email protected]>wrote: >> >>> >>> http://github.com/angrez/watir/commit/f4cb4c22a5c7cc2ee4fa1ba81d6e972cb7d34de0 >>> >>> >>> On Wed, Oct 14, 2009 at 11:15 PM, Ethan <[email protected]> wrote: >>> >>>> Can you link to the github fork in question? >>>> >>>> On Thu, Oct 15, 2009 at 00:13, Bret Pettichord <[email protected]>wrote: >>>> >>>>> >>>>> >>>>> On Wed, Oct 14, 2009 at 11:06 PM, Angrez Singh <[email protected]>wrote: >>>>> >>>>>> 2. In the future, it makes it easier if each change is in a separate >>>>>>> commit. >>>>>>> >>>>>> Will do that from next time onwards. >>>>>> >>>>>>> 3. I think i'm fine with close_all and click_no_wait, although i only >>>>>>> looked at the code briefly. Do we have tests for these? >>>>>>> 4. I'd like to hold off on logon and click_js_popup_button. These >>>>>>> appear to be new methods, not in Watir::IE and I'd like to review the >>>>>>> method >>>>>>> names and signatures, and consider these for 1.7.0. >>>>>>> >>>>>>> We need click_js_popup_button method to click the buttons on >>>>>> javascript alerts. Thats why I added click_no_wait method. Earlier pop up >>>>>> handling was different. So I think we should either add all or just >>>>>> close_all method. Yes there are unit test cases of each new function. >>>>>> >>>>> >>>>> I think the method for doing this is different in Watir::IE. I'm >>>>> wondering if we want to introduce an inconsistency here. >>>>> >>>>> Bret >>>>> >>>>> -- >>>>> Bret Pettichord >>>>> Lead Developer, Watir, www.watir.com >>>>> >>>>> Blog, www.io.com/~wazmo/blog <http://www.io.com/%7Ewazmo/blog> >>>>> Twitter, www.twitter.com/bpettichord >>>>> >>>>> >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> [email protected] >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> [email protected] >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >>> >>> >>> -- >>> Bret Pettichord >>> Lead Developer, Watir, www.watir.com >>> >>> Blog, www.io.com/~wazmo/blog <http://www.io.com/%7Ewazmo/blog> >>> Twitter, www.twitter.com/bpettichord >>> >>> >>> _______________________________________________ >>> Wtr-development mailing list >>> [email protected] >>> http://rubyforge.org/mailman/listinfo/wtr-development >>> >> >> >> _______________________________________________ >> Wtr-development mailing list >> [email protected] >> http://rubyforge.org/mailman/listinfo/wtr-development >> > > > > -- > Bret Pettichord > Lead Developer, Watir, www.watir.com > > Blog, www.io.com/~wazmo/blog <http://www.io.com/%7Ewazmo/blog> > Twitter, www.twitter.com/bpettichord > > > _______________________________________________ > Wtr-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/wtr-development >
_______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
