Everything looks good. Make sure to update versions, tag and release, otherwise you're golden. Interesting work on the IE9 changes, they've been surprisingly backward compatible aside from minor nits until this version.
-c On Tue, Jun 14, 2011 at 5:33 PM, Hugh McGowan <colinsda...@gmail.com> wrote: > Yeah I think that was the last one and I was hoping to release tonight. Is > there anything I need to do other than what I've done for the RCs? > > Thanks! > Hugh > > Message sent from iPhone > > On Jun 14, 2011, at 1:10 PM, Jarmo <jarm...@gmail.com> wrote: > > > I have a suggestion just go with the release after you've fixed some > > critical bugs (it seems that happens few rc-s ago already) or > > otherwise you will end up releasin rc-s after rc meaning that there's > > even more changes, which makes it more dangerous to upgrade. Small > > steps are the win to success, so just go with the release. I'd suggest > > that you could even go with the release right now since highlighting > > was broke already and couldn't get any worse :) > > > > J. > > > > On Tue, Jun 14, 2011 at 8:53 PM, Hugh McGowan <colinsda...@gmail.com> > wrote: > >> 1.9.0.rc7 makes highlighting work - in IE9, changing currentstyle has no > >> effect and in some cases will throw a DOM access denied js error. Now > style > >> is used to toggle the background color. I left all other references to > style > >> as they were. > >> > >> Thanks! > >> Hugh > >> > >> > >> > >> _______________________________________________ > >> Wtr-development mailing list > >> Wtr-development@rubyforge.org > >> http://rubyforge.org/mailman/listinfo/wtr-development > >> > > _______________________________________________ > > Wtr-development mailing list > > Wtr-development@rubyforge.org > > http://rubyforge.org/mailman/listinfo/wtr-development > _______________________________________________ > Wtr-development mailing list > Wtr-development@rubyforge.org > http://rubyforge.org/mailman/listinfo/wtr-development >
_______________________________________________ Wtr-development mailing list Wtr-development@rubyforge.org http://rubyforge.org/mailman/listinfo/wtr-development
