> That sounds like the best approach - I'll add the parameter soon.
Hi Julian,
Can I just summarise my understanding. If it was not what you intended,
please let me know.
1) You don't need a patch file from me, but I'll happily submit one if you
like.
2) You will add 'bool showPrintDialog' to:
- DoPrint,
- PrintFile,
- PrintBuffer,
In richtextprint.cpp & richtextprint.h. If I missed anything out, please
let me know, because I need to keep my code in synch manually until I reach
2.9.0.
I have a few questions:
1) wxPerl with this change implemented in wxWidgets only crashes unless the
wrapping code is changed in conjunction with it.
1a) I guess the same is true of wxPython, wxRuby and which other
distributions?
1b) Is there a contact name for each distribution that we should contact?
1c) Can we agree a timing, so that the code changes will be synchronised?
2) In wxPerl will need to put a piece of code like this in
RichTextPrinting.xsp:
#if WXPERL_W_VERSION_GE(2, 9, 0 )
bool PrintBuffer(const ........, , bool showPrintDialog);
bool PrintFile(const ........, , bool showPrintDialog);
.
.
.
#else
bool PrintBuffer(const ........);
bool PrintFile(const ........);
.
.
.
#endif
I will submit a patch with that change to Mark Dootson.
Will you put the change in all of 2.9.x? So the above code is correct, or
should it be 2.9.1 or something?
3) Finally, I got a corrupted printer driver on Friday, then I stuffed cups
and had to do a full reinstall this afternoon. I just want to do some final
testing before it goes out, if that's OK.
Thanks for all your help: it's been fun, and I even learned a new debugging
trick from Robin!
Regards
Steve
