Hi Steve,

From the wxPerl end following your work sorting out the best way to do this, the code change is simple enough so I have committed to SVN. Thanks for doing the hard work.

You'll have to role your own wxWidgets from their SVN though to use it.

A quicker hack for your own development would be to apply Julian's patch to the 2.9.3 source and patch your local Wx so that the conditional for the new method is against 2.9.3 rather than 2.9.4.

Even though the change is trivial, it isn't practical to backport to 2.9.3 because it changes the method signatures (adds a param) and our Wx XS code has to decide which to use at compile time based on the wxWidgets release version.

If you could post your Perl based workaround (I understood that you have one?) that would be great as I can add it to the Wx::Demo.

Regards

Mark



On 19/03/2012 01:14, Steve Cookson wrote:
Hi Mark,

Julian has put an extra flag in Wx::RichTextPrinting at my request to allow
::Print to work with OR without the print dialog box popping up.  It
therefore needs an extra flag (showPrintDialog) to be passed as the second
flag in two methods:

- PrintFile,
- PrintBuffer,

I will send you a patch in the form below, when I get confirmation that
Julian has restricted the change to 2.9.4.

If that is the case Wx will not install with RichTextPrinting without this
patch ( I hope for this version only).

There are more details in my other email.

Thanks and regards

Steve


#if WXPERL_W_VERSION_GE(2, 9, 4 )

        bool PrintBuffer(const ........, , bool showPrintDialog);
        bool PrintFile(const ........, , bool showPrintDialog);
        .
        .
        .

#else
        bool PrintBuffer(const ........);
        bool PrintFile(const ........);
        .
        .
        .

#endif

I will submit a patch with that change to Mark Dootson.

Will you put the change in all of 2.9.x? So the above code is correct, or
should it be 2.9.1 or something?






Reply via email to