Re: [X2go-Dev] New session param for .x2goclient/sessions file (was Re: Change Title of Frontend of Pyhoca)

[Mike Gabriel]

Hi Alex,

On Mi 30 Nov 2011 10:45:09 CET Oleksandr Shneyder wrote:

Am 30.11.2011 10:00, schrieb Mike Gabriel:

Hi Alex, hi Edwin,

On Fr 25 Nov 2011 12:56:02 CET Edwin Hernán Hurtado Cruz wrote:

That's Great!!!

That solution works perfect for me!!!!

Anyway, I was wondering If its possible to change it in the
client-side...

Thanks!!!

Today I have improved client-side session title renaming in
x2gostartagent (package: x2goserver).

And: I have added a session profile parameter to .x2goclient/sessions
when using pyhoca-gui (python-x2go).

The new session profile parameter's name is: sessiontitle.

If sessiontitle is set to a non-empty string, python-x2go will export
the env variable ,,X2GO_SESSION_WINDOW_TITLE before calling
x2gostartagent on the server-side.

The x2gostartagent script will notice that $X2GO_SESSION_WINDOW_TITLE is
defined and it will use this string as the session window title (+
X2GO-<session_id> in parentheses).

@Alex: could you please take a look at my latest x2goserver commits?
Maybe such a feature could be interesting for x2goclient itself. It
would be nice if we could use the same session profile parameter (i.e.
,,sessiontitle'').

x2go client and plugin using window title for searching window with
agent session. That will be needed if client should change parameters of
such window, for example - hide window decorations, resize window or
embed it in other window. Allowing user to change a window title can
break functionality of x2go client and plugin.

Ok, I did not know this... Sorry!!!



For X11FindWindow a patch possibly could be this:

<quote>
diff --git a/onmainwindow_part4.cpp b/onmainwindow_part4.cpp
index 76fd224..3db23e1 100644
--- a/onmainwindow_part4.cpp
+++ b/onmainwindow_part4.cpp

             {
                 QString title ( wname );
                 XFree ( wname );
-                if ( title==text )
+                if ( title.indexOf(text) != -1 )
                 {
                     proxyId=child_list[i];
                     break;
</quote>

But for Windows (wapiFindWindow function), I am not so sure...



--

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Still, I think the feature would be nice. Couldn't we provide a change in x2goclient that allows to change the session window title as long as the identifier X2GO-<session_id> stays within the title? That could be assured on the server-side and currently (with the latest x2goserver commits) is the case anyway. @@ -2359,7 +2359,7 @@ long ONMainWindow::X11FindWindow ( QString text, long rootWin ) Mike (who would love to make the session window renaming feature and find a way how to handle that with x2goclient, including old x2goclient versions)

pgpGx1KJ8tun3.pgp
Description: Digitale PGP-Unterschrift

_______________________________________________
X2go-Dev mailing list
X2go-Dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/x2go-dev