Hi Ilene, >> you could just append a comment to 17400 I've added patches for bug #17400.
>> Is getting this patch committed a prerequisite for the extension work? No, not at all. It's just that my changes (not for #17400) are for "is-last" optimization. This feature is not complicated, but it involved changes to existing 20 files, plus 2 new files were created. So I thought, it'd be good to go through the work-flow on this example first, as the changes for extension mechanism are broader. I'll create new enhancement request in bugzilla for is-last optimization with diffs and new files. Thanks, Dimitry -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 11, 2003 16:43 To: [EMAIL PROTECTED] Subject: RE: position() = last() optimization feature request Hi, The best thing to do is to attach a patch to the relevant bug report in bugzilla. If you want to open a new bug report for the bug you found you could do that, or if it makes sense you could just append a comment to 17400. Follow these guidelines for creating a patch: http://xml.apache.org/source.html#Patches. I can't say for sure how long it will take for someone to review and commit the patch, but by attaching it to the bug report, you can be sure it won't be forgotten. You should also add the "PatchAvailable" keyword to the bug report. Is getting this patch committed a prerequisite for the extension work? Thanks, Ilene. ------ "Voytenko, Dimitry" To: "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]> <[EMAIL PROTECTED] cc: data.com> Subject: RE: position() = last() optimization feature request 03/11/2003 03:00 PM Please respond to xalan-dev Hi, Could anyone please answer the questions below? I'm just not sure how much time this process usually takes. Would it help if I posted (should I) these changes as attachement to bugzilla? Would it help if I created "diff" files with the CVS revision? I want to get back to extension stuff and this part is sort of holding me back. Thanks, Dimitry E Voytenko -----Original Message----- From: Voytenko, Dimitry [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 05, 2003 13:23 To: '[EMAIL PROTECTED]' Subject: RE: position() = last() optimization feature request Hi, I found one more bug in AxesWalker and fixed it. Plus I also fixed http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17400 in org.apache.xpath.axes.ReverseAxesWalker, since I fixed it in AxesWalker before. I rerun conformance tests for both latest build and my changes again, including latest position112 and 113 tests. As you will be able to see from results of comparison, everything is the same, except two fixed failures: 112 and 113 in category position. http://www.sectorbase.com/tmp/islast-20030305.zip http://www.sectorbase.com/tmp/islast-test-20030305.zip I'm also wondering, what are the next steps in this process? Should I do anything else to ensure stability of the code? When do you plan to submit these changes? etc. Thanks, Dimitry E Voytenko _____________________________________________________ Revere Data, LLC, formerly known as Sector Data, LLC, is not affiliated with Sector, Inc., or SIAC.
