[ http://issues.apache.org/jira/browse/XALANJ-2172?page=comments#action_12315878 ]
Brian Minchau commented on XALANJ-2172: --------------------------------------- Are there going to be any additional testcases to test the JNDI functionality that is being added? This would require J2EE environment to test. If someone wants to use this code contribution, allows users in a J2EE environment, to specify the JNDI name for the connection pool and invoke the JNDI methods to connect to the pool. To build this code as part of Xalan it should build just fine, but to use it you need a J2SE environment. The new code, a new class, JNDIConnectionPool, which wrapers the connection pool interface and maps it to the JNDI connection pool class. > JNDI code contribution, samples to use Derby > -------------------------------------------- > > Key: XALANJ-2172 > URL: http://issues.apache.org/jira/browse/XALANJ-2172 > Project: XalanJ2 > Type: Improvement > Reporter: Brian Minchau > Assignee: John Gentilin > > I'm opening this issue to track the status of John Gentilin's contribution of > Eric's code for new JNDI work. > John has also reworked some samples to use Derby (hope I'm expressing this > correctly). > The new code will more easily create a database and run code/tests. > The amount of setup needed to get involved in this code was rather > high, one needs to install a database management system, plus get > the JDBC libraries, etc. Derby has an embeded version where all > you need to do use a jar file. > John G. has reviewed Eric's JNDI code, > and integrated/tested on his > system. Eric will test in a JNDI environment. > One new class, the rest is patches to existing parts. > Instant DB is no longer used, MySQL is not used and John G. has reworked > the examples to use Derby ( http://incubator.apache.org/projects/derby.html ) > Rather than include the Derby jars in the distribution, or in the > ./lib directory or the ./examples directory, we should propably point > users to where they can get the jars. For example we no longer ship > the Jakarta bsf.jar with our distribution. > If the jars go in ./test/java/bin that is OK, it is not part of > the distribution, and the smoketest could use them. > The old ./instantdb that can go. > John will be providing documentation changes as well. > Yash has agreed to review. > There are still open issues on this one regarding dependencies. > Please record discussion/patches/reviews in this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
