[
http://issues.apache.org/jira/browse/XALANJ-2172?page=comments#action_12316840
]
Sarah McNamara commented on XALANJ-2172:
----------------------------------------
John, thanks for the clarifications in your previous append. I'm glad that you
were able to use reflection to avoid the
need for the jdbc-std-ext.jar.
I had a quick peek at your new patches. Just to let you know, the
xml-xalan/java/bin directory is gone. As part of
the doc changes in XALANJ-2170, I fixed XALANJ-1556 and put this comment in
XALANJ-2170:
"....The biggest change in this patch is a proposed restructuring of the
xalan java cvs
so that licenses and notices are under a licenses directory, tools (such
as stylebook,
ant, jlex, java_cup, etc) are under a tools directory, and runtime jar
dependencies are
under a lib directory. The bin directory will be removed. "
[Please extract the latest code from xml-xalan/java to see the updates].
So, the runDerby.bat/.sh and runXalan.bat/.sh files in your patch need to be
slightly reworked to reflect the new
location of _PARSER_JAR and _XML-APIS_JAR (now located in xml-xalan/java/lib)
and _JAR_DIR (which I
think you'll also want to have point to xml-xalan/java/lib).
As to the location of where to put the derby.jar and derbytools.jar, you can
put them in either xml-xalan/java/tools
or xml-xalan/test/tools directory. Just so you're aware, the
xml-xalan/java/tools directory is not included in the binary
distribution (ie. xalan-j_2_7_0-bin.tar.gz/.zip); it is only included in the
source distribution package
(ie. xalanj-2.7.0-src.tar.gz/.zip) since the theory is that the jars in the
tools directory are not required at
runtime ... they are only required to 'build' the project and its
documentation. So, regardless of where you put the
derby jars, I think the samples page in the documentation needs to mention that
the user needs to download the
jars from the Derby project. This model of not distributing 3rd party
dependent jars is consistent with the
approach we now use for people who want to use non-java extensions (ie. they
need to obtain bsf.jar from the
jakarta bsf project). For what its worth, my preference would be to put the
derby jars in xml-xalan/test/tools
as we require these jars to run/test the sql samples.
I also noticed a typo in GETTING_STARTED.txt. On the line
+runXalan.bar -XSL basic-connection/dbtest.xsl
I believe you meant to have it read
+runXalan.bat -XSL basic-connection/dbtest.xsl
> JNDI code contribution, samples to use Derby
> --------------------------------------------
>
> Key: XALANJ-2172
> URL: http://issues.apache.org/jira/browse/XALANJ-2172
> Project: XalanJ2
> Type: Improvement
> Reporter: Brian Minchau
> Assignee: John Gentilin
> Attachments: Xalan-SQL-JNDI-with-reflection.txt, XalanSQLExamples.txt,
> derby-jars.zip
>
> I'm opening this issue to track the status of John Gentilin's contribution of
> Eric's code for new JNDI work.
> John has also reworked some samples to use Derby (hope I'm expressing this
> correctly).
> The new code will more easily create a database and run code/tests.
> The amount of setup needed to get involved in this code was rather
> high, one needs to install a database management system, plus get
> the JDBC libraries, etc. Derby has an embeded version where all
> you need to do use a jar file.
> John G. has reviewed Eric's JNDI code,
> and integrated/tested on his
> system. Eric will test in a JNDI environment.
> One new class, the rest is patches to existing parts.
> Instant DB is no longer used, MySQL is not used and John G. has reworked
> the examples to use Derby ( http://incubator.apache.org/projects/derby.html )
> Rather than include the Derby jars in the distribution, or in the
> ./lib directory or the ./examples directory, we should propably point
> users to where they can get the jars. For example we no longer ship
> the Jakarta bsf.jar with our distribution.
> If the jars go in ./test/java/bin that is OK, it is not part of
> the distribution, and the smoketest could use them.
> The old ./instantdb that can go.
> John will be providing documentation changes as well.
> Yash has agreed to review.
> There are still open issues on this one regarding dependencies.
> Please record discussion/patches/reviews in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
