Lots of great feedback. I can see the need for us to implement more process around XAP releases. We can learn a lot from other projects in this area. I've started researching this and will start a new thread to kick off a release process/criteria discussion.
I agree we should incorporate Robert's RAT licensing auditing tool into our release process so we detect these issues earlier. We should also consider drafting some coding standards or boilerplate templates for various types of XAP files which incorporate correct licensing information. More info on Robert's RAT at these links: http://code.google.com/p/arat/ http://www.jroller.org/page/robertburrelldonkin I've tested the samples and documentation. The changes suggested and implemented by Bob and Rob over the weekend look good. The samples all load and run in IE 6 and FF 2.0, and they all demonstrate something. I think they are good enough for this release, but I have some specific feedback on improving each sample that I'll put in a separate email thread. -Scott Boyd On 1/28/07, Bob Buffone <[EMAIL PROTECTED]> wrote:
Robert, Thanks for taking a look into this; we will fix the licensing concerns in the email. I embedded my comments into your. Xapians, let's make running the RAT tool part of our release process. Bob (Buffone) On 1/27/07, Scott Boyd <[EMAIL PROTECTED]> wrote: > Thanks to everyone for all the work that went into making this release so far! > > I have tagged the XAP trunk in the SVN repository as 0.3.0 and posted > a release candidate at: http://people.apache.org/~sboyd/xap-release/ > > Please vote on releasing these packages as Apache XAP 0.3.0. > > The vote is open for the next 72 hours, and passes if at least three > +1 votes are cast. Then the Apache Incubator must vote to allow this > release. For more information on the voting process, please review > http://www.apache.org/foundation/voting.html#ReleaseVotes. > > [ ] +1 Release the packages as Apache XAP 0.3.0 [ ] -1 Do not release > the packages because... some comments and questions i'm a little confused by the content of http://svn.apache.org/repos/asf/incubator/xap/trunk/NOTICE.txt - does XAP ship roller (or is this just a cut and paste typo)...? -------------- This was a cut and paste error and has already been fixed. We were going to use the roller notice as a template then forgot to use it as a template. -------------- ran RAT against trunk. there seem to be a *lot* of files which lack license headers. it's important to be able to track the origins of files. all source documents in formats capable of accepting comments and of being copyrighted which are created as original contributions or which arrive as part of a software grant need the appropriate apache header. it's important to understand which files in the source tree were not donated under a software grant or a CLA. this is tough for a project like XAP which includes a lot of scripts within the source tree. i need to understand the origins of the source before i can check that the release is ok i may have some more questions later (once i've modified RAT so that it understands the licenses in XAP better) but i have a few now. http://svn.apache.org/repos/asf/incubator/xap/trunk/unittests/jsunit/ seems to contain a lot of source packaged under net.jsunit without apache headers. is this imported from another open source project? -------------- This source was imported from the jsunit project but doesn't seem to have the license header in the file. We will look into this and fix the problem. -------------- http://svn.apache.org/repos/asf/incubator/xap/trunk/samples/ contains quite a few .xal files without headers. were these contributed to apache? if so, does the .xal format accept xml style comments? -------------- The .xal files are just xml documents we will add the header to these files. The intention was to have the files be contributed to apache. -------------- there are a number of javascript files in http://svn.apache.org/repos/asf/incubator/xap/trunk/codebase/src/xap/ without license headers. is this code contributed to apache or third party source? -------------- Again we will add the header to these files. -------------- the headers in http://svn.apache.org/repos/asf/incubator/xap/trunk/codebase/src/google/ README.txt don't match the release license. have we talked to google (greg stein, say) about obtaining some clearer source...? -------------- Not sure about this one, we need to look into this. Back in June we did have a thread on this, I will dig it up. -------------- just FYI http://svn.apache.org/repos/asf/incubator/xap/trunk/buildsystem/buildscr ipts/doctool/narcissus/ is MPL/GPL/LGPL. the proposed license policy (http://people.apache.org/~cliffs/3party.html) would prevent the inclusion of MPL'd javascript. -------------- It looks like we can't include the Narcissus files used by JSDoc in our distribution. Probably we can make it a 3rd party dependency in the short-term and modify the readme. Narcissus: http://lxr.mozilla.org/mozilla/source/js/narcissus/ -------------- http://svn.apache.org/repos/asf/incubator/xap/trunk/buildsystem/JSDoc-1. 9.9.2 lacks a lot of headers. is it generated, imported from outside source, or something else? -------------- Same as the above comment, we will make it a 3rdparty dependency. -------------- - Robert
