Andrea, Sylvester: Quite some time ago, Andrea raised an objection to the spec description of disambiguation behavior, which I should have addressed, but didn't:
http://xbiblio-devel.2463403.n2.nabble.com/disambiguation-one-more-tt5131926.html#a5133985 Rintze has proposed a revision that clarifies the behavior: https://github.com/citation-style-language/documentation/pull/16 Reviewing the amendments, I was reminded of a flaw in citeproc-js, which in some situations was failing to drop names that do not contribute to disambiguation. The failure is reflected in some of the fixtures in the test suite. I took another look at my code, and managed to clean up the behavior. The effect can be seen in the following changeset: https://bitbucket.org/bdarcus/citeproc-test/changeset/e4225e251798 The affected fixtures are linked below. Please take a look at them, and let us know whether you approve of the new behavior. The effect on the specification is outlined in comments to Rintze's github pull request, linked above. https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AddNamesFailure.txt https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AddNamesFailureWithAddGivenname.txt https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AndreaEg1.txt https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_ByCiteRetainNamesOnFailureIfYearSuffixNotAvailable.txt Many thanks, Frank ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ xbiblio-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbiblio-devel
