Hi Frank, sorry I'm so slow in catching up... as usual.
Frank Bennett <[email protected]> writes: > Andrea, Sylvester: > > Quite some time ago, Andrea raised an objection to the spec > description of disambiguation behavior, which I should have addressed, > but didn't: > > > http://xbiblio-devel.2463403.n2.nabble.com/disambiguation-one-more-tt5131926.html#a5133985 > > Rintze has proposed a revision that clarifies the behavior: > > https://github.com/citation-style-language/documentation/pull/16 > > Reviewing the amendments, I was reminded of a flaw in citeproc-js, > which in some situations was failing to drop names that do not > contribute to disambiguation. The failure is reflected in some of the > fixtures in the test suite. I took another look at my code, and > managed to clean up the behavior. The effect can be seen in the > following changeset: > > https://bitbucket.org/bdarcus/citeproc-test/changeset/e4225e251798 > > The affected fixtures are linked below. Please take a look at them, > and let us know whether you approve of the new behavior. The effect on > the specification is outlined in comments to Rintze's github pull > request, linked above. > > > https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AddNamesFailure.txt > > https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AddNamesFailureWithAddGivenname.txt > > https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_AndreaEg1.txt Yes, I agree. > > https://bitbucket.org/bdarcus/citeproc-test/src/beda343d95bc/processor-tests/humans/disambiguate_ByCiteRetainNamesOnFailureIfYearSuffixNotAvailable.txt I'm not so sure, here. I think that instead of: Asthma et al. (1990); Asthma et al. (1990); Dropsy, Enteritis, X. Fever (2000); Dropsy, Enteritis, Y. Fever (2000) it should be: Asthma, Bosworth Bronchitis, et al. (1990); Asthma, Beauregarde Bronchitis, et al. (1990); Dropsy, Edward Enteritis, et al. (2000); Dropsy, Ernie Enteritis, et al. (2000) When disambiguate-add-names fails to disambiguate a cite, while in the 1.0 specification all names should be shown regardless "et-al" limitations, the amendments now require the minimum effort to be used: If cites cannot be (fully) disambiguated by expanding the rendered names, and if ``disambiguate-add-names`` is set to "true", then the names still hidden as a result of et-al abbreviation after the disambiguation attempt of ``disambiguate-add-names`` are added one by one to all members of a set of ambiguous cites, until no more cites in the set can be disambiguated by adding *expanded* names. This applies also to: 1. disambiguate_ByCiteBaseNameCountOnFailureIfYearSuffixAvailable Not: Asthma, Bronchitis, Cold (1990a); Asthma, Bronchitis, Cold (1990b); Dropsy, Enteritis, X. Fever (2000); Dropsy, Enteritis, Y. Fever (2000) But: Asthma, Bosworth Bronchitis, et al. (1990); Asthma, Beauregarde Bronchitis, et al. (1990); Dropsy, Edward Enteritis, et al. (2000); Dropsy, Ernie Enteritis, et al. (2000) 2. disambiguate_ByCiteGivennameExpandCrossNestedNames Not: J. Doe, Jane Roe, Robert Jones; J. Doe, Josephine Roe, R. Jones; J. Doe, Jane Roe, Richard Jones But: J. Doe, Jane Roe, Robert Jones; J. Doe, Josephine Roe, et al.; J. Doe, Jane Roe, Richard Jones 3. disambiguate_ByCiteRetainNamesOnFailureIfYearSuffixNotAvailable Not: Asthma et al. (1990); Asthma et al. (1990); Dropsy, Enteritis, X. Fever (2000); Dropsy, Enteritis, Y. Fever (2000) But: Asthma, Bosworth Bronchitis, et al. (1990); Asthma, Beauregarde Bronchitis, et al. (1990); Dropsy, Edward Enteritis, et al. (2000); Dropsy, Ernie Enteritis, et al. (2000) 4. disambiguate_AllNamesBaseNameCountOnFailureIfYearSuffixAvailable: the first part is not correct (this is the old behavior). Not: Asthma, Bronchitis, Cold (1990a); Asthma, Bronchitis, Cold (1990b); But: Asthma et al. (1990a); Asthma et al. (1990b); 5. disambiguate_YearSuffixAtTwoLevels: I'm not entirely sure, here. Not: Smith, Jones & Brown (1986a); Smith, Jones & Brown (1986b); Smith, Jones, Brown, et al. (1986a); Smith, Jones, Brown, et al. (1986b) But: Smith et al. (1986a); Smith et al. (1986b); Smith et al. (1986c); Smith et al. (1986d) Other problematic tests: - disambiguate_ByCiteGivennameShortFormInitializeWith: initialize-with is set and so the full name (Smith) should be shown. And so: Not: Roe J Doe; A Doe Smith; Smith But: Roe J Doe; A Doe Thomas Smith; Ted Smith - disambiguate_ByCiteDisambiguateCondition: "disambiguate" condition should be applied *afetr* year-suffix if the year suffix is not enough: Not: Doe & Roe, <i>Book A</i> (2000); Doe & Roe, <i>Book B</i> (2000) But: Doe et al. (2000a); Doe et al. (2000b) I would also like to address the problem of those tests implying a stateful processor. We could move them in a different sub-directory, maybe. These are the ones I remember in the disambiguate group: disambiguate_AllNamesSimpleSequence disambiguate_DisambiguateWithThree disambiguate_DisambiguateWithThree2 disambiguate_YearSuffixFiftyTwoEntries disambiguate_YearSuffixAtTwoLevels Thanks, -- andrea ------------------------------------------------------------------------------ Get your Android app more play: Bring it to the BlackBerry PlayBook in minutes. BlackBerry App World™ now supports Android™ Apps for the BlackBerry® PlayBook™. Discover just how easy and simple it is! http://p.sf.net/sfu/android-dev2dev _______________________________________________ xbiblio-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbiblio-devel
