On Mon, Nov 1, 2010 at 6:28 PM, Adam Lee <[email protected]> wrote:
>  *addon -   skin.xperience
>  *version - 1.1.0
>  *url -
> http://xboxmediacenter.svn.sourceforge.net/svnroot/xboxmediacenter/Xperience
> 1.1/
>  *revision - r110110
>  *branch - master
>  *xbmc version - dharma,
>
> ------------------------------------------------------------------------------
> Nokia and AT&T present the 2010 Calling All Innovators-North America contest
> Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
> http://p.sf.net/sfu/nokia-dev2dev
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>

Hi Adam.

Nice to finally see some of you Blackbolt guys here :)

Sorry for the lack of a quick response. It seems that the skin is in
really good shape, thanks for paying attention to the guidelines.
Please fix up these small things. After that I'll do a more thorough
review, but it looks pretty good to me.

1. Please remove exe/dll/bat from media/
2. I haven't tested locally yet, but from past experience with
Transparency!, xpr'd animations don't work well. Mind testing them?
For Transparency!, we moved them out of media/ as a (temporary?) fix.
3. Could you please kill all the svn exec props?
4. The following files are 1x1, which has proven to be a problem when
xpr'd. 4x4 is safe.
    Warning: ./media/overlays/debug/loadedxml.PNG has dimensions of 1x1
    Warning: ./media/windows/common/black.png has dimensions of 1x1
    Warning: ./media/dialogs/video-info/line.png has dimensions of 1x1
    Warning: ./media/dialogs/music-info/line.png has dimensions of 1x1
    Warning: ./media/osd/media-guide/line.png has dimensions of 1x1
    Warning: ./media/osd/nowplaying/videoback.png has dimensions of 1x1
    Warning: ./media/views/music panel/other/list_line.png has dimensions of 1x1
    Warning: ./media/views/poster/posterview/line.png has dimensions of 1x1

5. Please fix up these 2 small xml nits. I'll send a patch along later
if you'd like.

skin.xperience/720p/Include_Categories-Recently-Added.xml:696: parser
error : Comment not terminated
<!-- <control type="button" id="2000">
                        <description
<!-- After Library Update -->
  ^
skin.xperience/language/English/strings.xml:351: parser error : Input
is not proper UTF-8, indicate encoding !
Bytes: 0xB7 0x20 0x42 0x72
                <string id="31427">Manage Your Installed Addons �
Browse for and Install Addon


Thanks,
Cory

------------------------------------------------------------------------------
Achieve Improved Network Security with IP and DNS Reputation.
Defend against bad network traffic, including botnets, malware, 
phishing sites, and compromised hosts - saving your company time, 
money, and embarrassment.   Learn More! 
http://p.sf.net/sfu/hpdev2dev-nov
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to