Arne,

The same zip file works under both Dharma and Camelot (I put a decent amount of 
time making sure it works under both).  Some of your suggestions would break 
compatibility with Camelot and require me to publish two separate versions.  
Can we let those slide for the time being until Camelot slides off the radar 
(6months or so) ??  Specifically, I'm referring to:
4) default.tbn can be nuked


5) we supply script modules for
  - Beautiful Soup
  - elementtree
  -simplejson

(I still need to include them for Camelot but will use the <import addon=...>  
for Dharma. 


5) don't use os.getcwd(). this will break when we move to external
python soon. use addon.getAddonInfo('path')


(additional note:  os.getcwd() is only used when running under Camelot -- 
details in platform.py)

I will make the required changes for  1), 2), and 3)

Thoughts?

-sp


----- Original Message -----
From:Arne Morten Kvarving <[email protected]>
To:sp <[email protected]>
Cc:"[email protected]" <[email protected]>
Sent:Tuesday, November 23, 2010 10:53:05 AM
Subject:Re: [Xbmc-addons] [Zip Pull] MythBox for XBMC

On Mon, Nov 22, 2010 at 9:13 PM, sp <[email protected]> wrote:
> addon - script.mythbox
> version - 1.0.RC3
> url -  http://mythbox.googlecode.com/files/script.mythbox.1.0.RC3.zip
> revision - n/a
> branch - n/a
> xbmc version - dharma

some things to be done;

1) CHANGELOG.txt -> changelog.txt
2) no reason to have execute on LICENSE.txt
3) provides need to go within the <extension> tag, i.e.

<extension point="xbmc.python.script" library="default.py">
  <provides>video</provides>
</extension>
also i'd reckon video is a saner provides than executable - that way
it will show up in the video add-ons node.

4) default.tbn can be nuked
5) we supply script modules for
  - Beautiful Soup
  - elementtree
  -simplejson

you import these using

<import addon="script.module.beautifulsoup">
<import addon="script.module.elementtree">
<import addon="script.module.simplejson">

under the requires tag.

5) don't use os.getcwd(). this will break when we move to external
python soon. use addon.getAddonInfo('path')
6) not required, just a hint. if you use addon.getAddonInfo('profile')
you can ditch the whole getCacheDir thingie in platform.py.
additionally, you can get/set settings from the addon as well, so you
can also avoid a lot of the code in settings.py

arnem


------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to