On Mon, Apr 11, 2011 at 12:38 PM, Chase Williams <[email protected]> wrote: > What would have to be done to make that work? is that XBMC coding or > something that can be done within a skin? > > On Sat, Apr 9, 2011 at 5:22 PM, Jonathan Marshall > <[email protected]> wrote: >> >> On Sun, Apr 10, 2011 at 4:24 AM, Cory Fields <[email protected]> wrote: >>> >>> On Fri, Apr 8, 2011 at 11:50 PM, Wiz <[email protected]> wrote: >>> > Sorry about the skinshots. You can pull now. I would like to discuss >>> > the >>> > possibility of adding this "preview" feature as its had good feedback. >>> > >>> > *addon – skin.simplicity >>> > *version - 1.0.9 >>> > *url - git://github.com/wizardxbmcmods/simplicity-xbmc.git >>> > *revision - 0e84cd66c >>> > *branch - master >>> > *xbmc version - dharma >>> > >>> > >>> > >>> > >>> > -----Original Message----- From: Cory Fields >>> > Sent: Friday, April 08, 2011 1:03 PM >>> > To: Chase Williams >>> > Cc: XBMC ADDON LIST >>> > Subject: Re: [Xbmc-addons] [GIT PULL] Skin.Simplicity >>> > >>> > On Fri, Apr 8, 2011 at 9:46 AM, Chase Williams >>> > <[email protected]> >>> > wrote: >>> >> >>> >> *addon – skin.simplicity >>> >> *version - 1.0.9 >>> >> *url - git://github.com/wizardxbmcmods/simplicity-xbmc.git >>> >> *revision - 5aa52db034f >>> >> *branch - master >>> >> *xbmc version - dharma >>> >> >>> >> >>> >> >>> >> >>> >> >>> >> ------------------------------------------------------------------------------ >>> >> Xperia(TM) PLAY >>> >> It's a major breakthrough. An authentic gaming >>> >> smartphone on the nation's most reliable network. >>> >> And it wants your games. >>> >> http://p.sf.net/sfu/verizon-sfdev >>> >> _______________________________________________ >>> >> Xbmc-addons mailing list >>> >> [email protected] >>> >> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >>> >> >>> >> >>> > >>> > Cmon now.. what's up with these skinshots? I'm fine with quick fixups >>> > for the skins, but please don't try to slide this stuff in. If >>> > something needs to be fixed up from a previous pull, please commit it >>> > that way. >>> > >>> > I'm unable to test currently, but I assume this is some kind of skin >>> > demo feature? If so, why does your skin contain shots of the others? >>> > Surely there's a more reasonable way to do this? >>> > >>> > Please revert your last commit and commit only the fixes and I'll >>> > pull. We can discuss the rest after. >>> > >>> > Cory >>> > >>> >>> I'm a fan of the previews as well, though it needs more thought. Imo >>> the only ways to do it are: >>> 1. a script that reacts to screenshot/ folders or somesuch >>> 2. add a <screenshotfolder> to the addon.xml spec. This would be >>> pulled out of the zip and added to a new metadata zip. That way >>> screenshots could be fetched with the other metadata without >>> downloading the addon itself (otherwise it makes no sense, right?). >>> 2. Makes way more sense, but I wouldn't be opposed to 1. in the >>> short-term. >>> >>> Arne? >>> >>> Cory >>> >>> >>> ------------------------------------------------------------------------------ >>> Xperia(TM) PLAY >>> It's a major breakthrough. An authentic gaming >>> smartphone on the nation's most reliable network. >>> And it wants your games. >>> http://p.sf.net/sfu/verizon-sfdev >>> _______________________________________________ >>> Xbmc-addons mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> >> One way it could be done is to just have the images online and XBMC could >> just fetch them from there, using a multiimage control to point to the >> slideshow. A video preview could be done in the same way. Essentially the >> same as the changelog is currently done? >> >> Cheers, >> Jonathan > >
Ok, this is getting frustrating. You submitted a pull req for what I assume was a stable/tested skin. You noticed a problem and sent a req for a quick fixup, no problem so far. But with that fixup, lots of new stuff was added. I asked you to revert it and just include a fix for a problem. Now, I am getting ready to pull in the revised fixup, and again there is new code mixed in. A fix for a stable release should contain _only_ that fix. If you assure me that you're ok with me pulling now, I'll do it this once. But please, use the tools! a simple 'git revert HEAD' and search/replace is all that was needed here. Cory ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
