That's fine, but you still need to require it for Dharma. Rather than adding conditionals all over the place, _please_ create a branch for Dharma off and separately. This is going to turn to chaos if you try to support both with the same code...
Cory On Sun, May 8, 2011 at 4:37 PM, Wiz <[email protected]> wrote: > I added a condition that runs it if the version is 10.1 and uses the > included infolabels if it isnt. Is this acceptable? > > > Thanks, > > Chase > > -----Original Message----- From: Cory Fields > Sent: Monday, May 02, 2011 10:54 PM > To: Wiz > Cc: [email protected] > Subject: Re: [Xbmc-addons] [GIT PULL] skin.simplicity > > On Fri, Apr 29, 2011 at 11:59 PM, Wiz <[email protected]> wrote: >> >> Fixed. >> >> >>>> addon – skin.simplicity >>>> version - 1.2.0 >>>> url - git://github.com/wizardxbmcmods/simplicity-xbmc.git >>>> revision – 29ec30b3b >>>> branch - master >> >> >> >> Wiz >> >> >> -----Original Message----- From: Cory Fields >> Sent: Friday, April 29, 2011 3:28 PM >> To: Wiz >> Cc: [email protected] >> Subject: Re: [Xbmc-addons] [GIT PULL] skin.simplicity >> >> On Fri, Apr 29, 2011 at 4:07 AM, Cory Fields <[email protected]> wrote: >>> >>> On Wed, Apr 27, 2011 at 4:39 AM, Wiz <[email protected]> wrote: >>>> >>>> addon – skin.simplicity >>>> version - 1.2.0 >>>> url - git://github.com/wizardxbmcmods/simplicity-xbmc.git >>>> revision – 1e1c2cedc >>>> branch - master >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> WhatsUp Gold - Download Free Network Management Software >>>> The most intuitive, comprehensive, and cost-effective network >>>> management toolset available today. Delivers lowest initial >>>> acquisition cost and overall TCO of any competing solution. >>>> http://p.sf.net/sfu/whatsupgold-sd >>>> _______________________________________________ >>>> Xbmc-addons mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons >>>> >>>> >>> >>> Sorry for the delay, will review this and the other 2 pending skins >>> tomorrow. >>> >>> Regards, >>> Cory >>> >> >> Whoops, forgot to reply to list. >> >> Please fixup the two spacing issues and I'l pull: >> 720p/ViewsFileMode.xml lines 297 and 224. >> >> Thanks, >> Cory >> > > I see that recentlyadded was removed. Was this on accident or does > your skin no longer use it? Please remember that all skins in the > Dharma repository are for Dharma only. Or are you aiming for eden-pre > (which still has not been discussed/announced on this list, that's my > bad)? > > Cory > ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Xbmc-addons mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/xbmc-addons
